add API Gateway #89
Merged
add API Gateway #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| case class `AWS::ApiGateway::Account`( | ||
| name: String, | ||
| CloudWatchRoleArn: Option[String] = None, |
There was a problem hiding this comment.
I'm guessing this and a few other things should likely be Option[Token[_]] since they would like come in either as parameters or resource refs.
There was a problem hiding this comment.
updated in 7563774
|
Boo AWS documentation! I'm fine with just matching what they list as optional and updating as people find bugs. I marked a couple of places where we might want to use |
|
cool thanks for the contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for API Gateway on Cloudformation is not that good - it says that almost everything is Optional, but then when you actually run it, it has to be set. This works for my current use cases, but there are somethings that are probably not Option[_].