Fix errors in ApplicationAutoScaling models #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ress. - Changed StringBackedInt to Token[Int] for autoscaling group so that you can use parameters. - AmazonTag.Key is now a token, so that you can use functions. - Tested it with a real script: https://docs.aws.amazon.com/eks/latest/userguide/getting-started.html#eks-create-cluster - Step 3: point 5 (https://amazon-eks.s3-us-west-2.amazonaws.com/cloudformation/2018-08-30/amazon-eks-nodegroup.yaml)
- No longer use stringbackedint - copied contents from generated extension file to non-generated extension file
…rence roles (instead of requiring you to always configure your own roles in the template).
- Make GroupDescription a Token type.
…ress Add AssociatePublicIpAddress field to LaunchConfiguration.
…ameAndMakeToken Add GroupName support for security group.
Add EKS support and unit test.
tjcorr
reviewed
Jan 15, 2019
src/main/scala/com/monsanto/arch/cloudformation/model/resource/ApplicationAutoScaling.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/monsanto/arch/cloudformation/model/resource/ApplicationAutoScaling.scala
Outdated
Show resolved
Hide resolved
add dynamodb SSESpecification
Adds support for PointInTimeRecoverySpecification and Tags
…SizeFix Added Description fields. Changed fields to Token[...]
add support for AWS::EC2::VPCEndpoint
…ation-template-generator into eanderson13-policytype
tjcorr
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change to fix ScalingPolicy to have correct name for PolicyType field. See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-applicationautoscaling-scalingpolicy.html#cfn-applicationautoscaling-scalingpolicy-policytype
Also includes updating ServiceNamespace in ScalableTarget to have correct values. See https://docs.aws.amazon.com/autoscaling/application/APIReference/API_RegisterScalableTarget.html#autoscaling-RegisterScalableTarget-request-ServiceNamespace. This can also be achieved in the current version using a CustomNamespace.
This PR is paired with the non-breaking equivalent in PR #260. The expectation is that only one PR is accepted, or #260 is accepted as a bugfix version update and this PR is accepted as a major version update.