Add support for ContainerDefinition MountPoints #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TaskDefinition also validates that the any ContainerDefinitions' MountPoints' SourceVolume names matche one of the Volumes in the TaskDefinition.
|
Could this be merged? I need this so much. |
Tvaroh
reviewed
May 12, 2017
| MemoryReservation, MountPoints, Name, PortMappings, Privileged, ReadonlyRootFilesystem, Ulimits, User, | ||
| VolumesFrom, WorkingDirectory, None | ||
| ) | ||
|
|
||
| implicit val format: JsonFormat[ContainerDefinition] = new RootJsonFormat[ContainerDefinition] { | ||
| override def write(cd: ContainerDefinition) = { | ||
| val obj = JsObject( |
There was a problem hiding this comment.
MountPoints is missing from this object, so nothing is added to the result template.
There was a problem hiding this comment.
@jfklingler I haven't had a chance to confirm myself, can you respond to @Tvaroh 's comment?
|
@jfklingler Any comment on @Tvaroh 's note above? |
|
Sorry. I haven't had a chance to get back to this. I'll try to take a look next week. |
|
Finally got back around to this. Yeah, I completely overlooked the custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TaskDefinition also validates that the any ContainerDefinitions' MountPoints' SourceVolume names matche one of the Volumes in the TaskDefinition.
Fixes #163