Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Code Health #897

Closed
thedrow opened this issue Feb 27, 2015 · 2 comments · Fixed by #1428
Closed

Increase Code Health #897

thedrow opened this issue Feb 27, 2015 · 2 comments · Fixed by #1428

Comments

@thedrow
Copy link
Contributor

thedrow commented Feb 27, 2015

We have issues like mutable arguments or very broad exception clauses that can be narrowed down.
We also have field subclasses that change the signature of parent functions.

I had a pass on base/document.py on #893, #895 and #896 but there's a lot more work to be done on the rest of the code.
@thedrow
Copy link
Contributor Author

thedrow commented Feb 27, 2015

https://landscape.io/github/MongoEngine/mongoengine/81/modules/mongoengine/fields.py is in really bad shape for example.

@thedrow thedrow mentioned this issue Apr 29, 2015
Merged
@amcgregor amcgregor mentioned this issue Jun 23, 2016
Open
@wojcikstefan wojcikstefan mentioned this issue Dec 8, 2016
Merged
@wojcikstefan
Copy link
Member

Health of MongoEngine has been significantly improved in #1428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the health of this package MongoEngine/mongoengine
3 participants
@thedrow @wojcikstefan @MRigal