3 minor additions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and prevent destroying existing context on view close event
E.g.:
commands: {
'commandName': CommandConstructor
}
| @@ -35,7 +35,7 @@ | |||
| this.vent = {}; | |||
| _.extend(this.vent, Backbone.Events); | |||
| if (_.isFunction(this.initialize)) { | |||
| this.initialize(); | |||
| this.initialize.apply(this, arguments); | |||
There was a problem hiding this comment.
I like this idea in principle. Just curious if you have found a use case for it yet? Generally my Context objects have only served to map the commands. What sort of parameters are useful in the initialize() method?
There was a problem hiding this comment.
Yes, since I like the idea of all models living in the context, I pass some models into the constructor.
|
Just noticed I lost |
Note to self: don't add to pull requests while working on the train ;)
geekdave
added a commit
that referenced
this pull request
May 30, 2013
* Make Context pass arguments from constructor to initialize() following backbone conventions
* Allow bindContext() to also take an existing context instead of constructor
* Automatically map commands in Context.commands property E.g.: commands: { 'commandName': CommandConstructor }
|
Thanks for the contributions and the great discussion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've made three minor additions I find very useful:
E.g.:
commands: {
'commandName': CommandConstructor
}
I hope you find them useful. Best regards,
Jonas