From 9f06d688fa7f7a8bd585ad88ca6513bc50e57f43 Mon Sep 17 00:00:00 2001
From: cka-y <60586858+cka-y@users.noreply.github.com>
Date: Tue, 26 Nov 2024 10:55:41 -0500
Subject: [PATCH] chore: artifact action v3 upgrade (#1926)

---
 .github/workflows/docker.yml                      | 2 +-
 .github/workflows/end_to_end.yml                  | 6 +++---
 .github/workflows/notice_migration_generation.yml | 6 +++---
 .github/workflows/test_pack_doc.yml               | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 0d55eb7d89..ce80299f00 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -34,7 +34,7 @@ jobs:
           arguments: testAggregateTestReport
       - name: Persist aggregated test reports on failure
         if: ${{ failure() }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Test report - Java
           path: build/reports/tests/unit-test/aggregated-results/
diff --git a/.github/workflows/end_to_end.yml b/.github/workflows/end_to_end.yml
index f3f139df61..e40141ecfb 100644
--- a/.github/workflows/end_to_end.yml
+++ b/.github/workflows/end_to_end.yml
@@ -58,7 +58,7 @@ jobs:
         with:
           arguments: shadowJar
       - name: Persist gtfs-validator snapshot jar
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: gtfs-validator-snapshot
           path: cli/build/libs/gtfs-validator-*-cli.jar
@@ -78,7 +78,7 @@ jobs:
           echo "matrix=$DATASETS" >> $GITHUB_OUTPUT
       - name: Persist metadata
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: datasets_metadata
           path: scripts/mobility-database-harvester/datasets_metadata
@@ -94,7 +94,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: Download latest changes .jar file from previous job
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: gtfs-validator-snapshot
           path: gtfs-validator-snapshot
diff --git a/.github/workflows/notice_migration_generation.yml b/.github/workflows/notice_migration_generation.yml
index 00c3d1b820..7c399e7368 100644
--- a/.github/workflows/notice_migration_generation.yml
+++ b/.github/workflows/notice_migration_generation.yml
@@ -41,7 +41,7 @@ jobs:
         run: ./gradlew webClientRulesJSON
 
       - name: Upload previous rules.json
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: rules-${{ env.PREVIOUS_VERSION }}
           path: web/client/static/rules.json
@@ -55,13 +55,13 @@ jobs:
         run: ./gradlew webClientRulesJSON
 
       - name: Upload current rules.json
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: rules-${{ github.event.inputs.NEW_VERSION }}
           path: web/client/static/rules.json
 
       - name: Download all workflow artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
 
       - name: Validate download
         run: ls -la rules*
diff --git a/.github/workflows/test_pack_doc.yml b/.github/workflows/test_pack_doc.yml
index 350296a7dd..46f565c6f9 100644
--- a/.github/workflows/test_pack_doc.yml
+++ b/.github/workflows/test_pack_doc.yml
@@ -41,7 +41,7 @@ jobs:
           arguments: testAggregateTestReport --continue
       - name: Persist aggregated test reports on failure - Java ${{ matrix.java_version }} on ${{ matrix.os }}
         if: ${{ failure() }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Test report - Java ${{ matrix.java_version }} on ${{ matrix.os }}
           path: build/reports/tests/unit-test/aggregated-results/
@@ -71,7 +71,7 @@ jobs:
         with:
           arguments: shadowJar
       - name: Persist cli app jar
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Application - CLI executable - Java ${{ matrix.java_version }} JAR file -- ${{ matrix.os }}
           path: cli/build/libs/gtfs-validator-*-cli.jar
@@ -100,7 +100,7 @@ jobs:
         with:
           arguments: aggregateJavadoc
       - name: Persist javadoc
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Documentation - javadoc - Java ${{ matrix.java_version }} - ${{ matrix.java_version }}
           path: build/docs/javadoc/