This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 249
Keep "layouts" reference in React context, not in Redux store #97
Labels
Comments
Any exact pointers on what is causing an issue for you? |
I'm testing on #91 First, save it: http://localhost:3000/?debug_session=foo Receive this in store: Basicaly, persistState dump the current state to localStorage. Since functions can't be serialized to JSON, It would break persisState functionality |
Oh I see. Yeah I think we should use react context for this. Don't you think? |
Yup. Please read my comment at #40 |
So will move "layouts" (I just renamed "pageComponents" as "layouts" in master) out of the store, and will use context for this. |
MoOx
changed the title
Should not store function inside redux store
Keep "layouts" reference in React context, not in Redux store
Jan 24, 2016
👍 |
That's already good in master https://github.com/MoOx/statinamic/blob/813aafc3b32608a7281270610905f4000e95f133/src/ContextProvider/index.js |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
because functions can't be serialized to JSON. This breaks persistState in devTools
The text was updated successfully, but these errors were encountered: