Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Markdown head property type breaks layout #932

Closed
0x80 opened this issue Jan 8, 2017 · 2 comments
Closed

Markdown head property type breaks layout #932

0x80 opened this issue Jan 8, 2017 · 2 comments
Labels
needs investigation

Comments

@0x80
Copy link

0x80 commented Jan 8, 2017 •
edited
Loading

I created some posts with a type property, and found that it breaks the layout. It seems that layout is set as type on the object passed to the page component. It appears to still contain the layout value when a type is used in the head, but somewhere it breaks things because the layout is not being used in page rendering.

As a side note I think it would be useful to have a warning or error when setting a layout that is not registered. Currently it silently falls back to Page.
@MoOx
Copy link
Owner

MoOx commented Jan 9, 2017 •
edited
Loading

Indeed layout used is type || layout. Maybe this is not documented but it's like that since the beginning.
I guess we should show warnings indeed. Will revisit this for 1.0.0

@MoOx
Copy link
Owner

MoOx commented Mar 15, 2018

Probably not relevant with v1

@MoOx MoOx closed this as completed Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MoOx @0x80