Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-cli] better default configuration to reduce chances of accidental data leaks #48

Open
MoChilia opened this issue Jan 9, 2025 · 3 comments

Comments

@MoChilia
Copy link
Owner

MoChilia commented Jan 9, 2025

Description

The Azure cli has a tendency to be quite chatty and this can expose secrets stored in Azure in the logs of CI tools that run it.

There are a number of sensible configuration settings that can be applied to greatly reduced the chance of this happening:

core.only_show_errors=true
core.error_recommendation=off
core.collect_telemetry=false
logging.enable_log_file=false

These can either be set using az config or registered as environment variables. The latter being more secure as the AzureCLI@2 task in Azure pipelines ignores the global config by default.

Ideally azure-cli would detect it's running on a ci platform, using a package similar to is-ci.

This way command output isn't echo'ed to the log by default and also not written to disk where it can easily be intercepted.

I've suggested the actions-runner team would apply these settings on the GitHub Actions and Azure Pipelines hosted runners, but they feel it's up to the individual tools to act in a proper manner:

Expected behavior

Azure-cli is configured with sane CI/CD defaults.

There is an extension to Azure cli called init which provides sane automation defaults.

Actual behavior

Azure-cli is configured in standard interactive mode.

Copy link

github-actions bot commented Jan 9, 2025

Copy link

github-actions bot commented Jan 9, 2025

This issue is related to security. Please pay attention.

@MoChilia
Copy link
Owner Author

MoChilia commented Jan 9, 2025

Cite from actions/runner-image team: Thank you for your suggestion, but we prefer to use default settings since they are common for everyone. If you would like to change some behavior of Azure-cli you can try to do it in runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant