-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rewrite:core router] in non-hash mode, anchor-based navigation triggers the router resolution logic #1270
Comments
I think it should trigger it in that case, since hash can have route parameters and you'd want a redraw if they changed |
So, in non-hash mode, the router will parse parameters that happen after the pound sign? Routing to |
@pygy that specific case wouldn't work as expected, because query is supposed to comes before hash. |
In what scenario would you want to do that rather than It looks like an exotic use case compared to having anchors that work without triggering routing. |
Setting the hash of the location triggers
onpopsate
which triggers the route resolution logic.It means that if someone wants to use local anchors in a page/app, they'll have to take that quirk into account...
A partial solution would be to set a flag to
true
whensetPath()
is called and skip resolution in non-hash mode when it hasn't been set... But it probably breaks the back button, so it isn't satisfactory...The text was updated successfully, but these errors were encountered: