Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use program/end program for main programme in Mistra #5

Closed
pb866 opened this issue Dec 23, 2018 · 3 comments
Closed

Use program/end program for main programme in Mistra #5

pb866 opened this issue Dec 23, 2018 · 3 comments

Comments

@pb866
Copy link

pb866 commented Dec 23, 2018

In str.f, we should include a program str / end program str statement to make it clearer, where the main programme starts/end. Also, it is not quite clear, why the file is called str and we should consider to rename the file main routine to mistra.

@JosueBock
Copy link
Contributor

I agree that both changes would be fine, however much broader changes must be made in this file, so I will leave it for the moment (it will also require to update the manual, while at the moment it is consistent with the current model structure)

@rs028
Copy link
Contributor

rs028 commented Feb 20, 2019

@JosueBock Can you open an issue with more information on the broader changes that need to be made to str.f, please? (Also in reference to point 4 of issue #2).

@JosueBock
Copy link
Contributor

Main program has been explicitly identified using program / end program, and named "mistra"
See this commit : 7154573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants