Skip to content
This repository has been archived by the owner on Jun 3, 2023. It is now read-only.

names are not updating #11

Closed
UnknownPlayer13 opened this issue May 15, 2022 · 4 comments
Closed

names are not updating #11

UnknownPlayer13 opened this issue May 15, 2022 · 4 comments
Assignees
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@UnknownPlayer13
Copy link

i noticed that the names are not updating. The bot still displays the playernames from when i deployed the bot.
So lets say my ingame name is "test1" and the bot is getting deployed after that when i change my name to "Testdone1" it will always display the "test1" name in the leaderboard, even after 12 hours and even if i would deploy the bot again its the same result.

@Mirasaki Mirasaki self-assigned this May 16, 2022
@Mirasaki Mirasaki added the bug Something isn't working label May 16, 2022
@Mirasaki Mirasaki linked a pull request May 16, 2022 that will close this issue
@Mirasaki
Copy link
Owner

Mirasaki commented May 16, 2022

I've adjusted the automatic caching to be handled by our own client instead of the cftools-sdk caching in this pull request, but it looks like the unique identifier for the leaderboard data is actually survivor names - during my testing with name changing a new data entry for the new, renamed name will be created instead of overwriting the data that belonged to the previous name. Therefor, this isn't actually a bug with this bot, but an expected result from the CFTools Cloud API, an result that we, the bot, do not currently have any control over.

@Mirasaki Mirasaki added wontfix This will not be worked on help wanted Extra attention is needed question Further information is requested and removed bug Something isn't working wontfix This will not be worked on labels May 16, 2022
@Mirasaki
Copy link
Owner

I've changed the labels to help wanted and question, because I'm not completely sure this is something we don't have complete control over.

If anyone wants to do some debugging, change the DEBUG_LEADERBOARD_API_DATA variable in config/.env to true, restart the bot, use the leaderboard command, re-name in client server parameters, suicide in-game, use the leaderboard command again and compare the DEBUG tables displayed in the console.

I might do some more research later, but for now, this is on hold

@Mirasaki Mirasaki removed a link to a pull request May 16, 2022
@Mirasaki
Copy link
Owner

Pull request will go through, but it's unrelated to this issue.

@Mirasaki
Copy link
Owner

I've now looked into it, when a player renames using client parameters, the API creates a new data object for that player name instead of overwriting the old one. Therefor this is indeed not related to this specific application, but more a problem, or expected result, with the CFTools Cloud API. Closing this as there's nothing to be done about this on our side

@Mirasaki Mirasaki added invalid This doesn't seem right wontfix This will not be worked on and removed help wanted Extra attention is needed question Further information is requested labels May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants