Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snarkyjs-bindings] check if overrides.js and sed cmd are still necessary #13813

Open
dannywillems opened this issue Aug 2, 2023 · 0 comments

Comments

@dannywillems
Copy link
Member

dannywillems commented Aug 2, 2023

From Slack conv:

the stubs look different in jsoo master
for the function defines in overrides.js: https://github.com/ocsigen/js_of_ocaml/blob/master/runtime/sys.js#L85 and https://github.com/ocsigen/js_of_ocaml/blob/master/runtime/fail.js#L33
Running git diff 4.0.0 runtime/sys.js and git diff 4.0.0 runtime/fail.js on jsoo master.
'll give a try in the bumpup
I don't know if the attach_backtrace does smth interesting

At the moment, overrides.js overrides fail functions, caml_fatal_uncaught_exception and caml_raise_with_string to include the stack trace. However, looking quickly at jsoo master, it seems the backtrace is added?
It would simplify the code and the integration in dune.

Maybe also we could get rid of the sed cmd when bumping jsoo

@dannywillems dannywillems changed the title [snarkyjs-bindings] check if overrides.js is still necessary [snarkyjs-bindings] check if overrides.js and sed cmd are still necessary Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant