Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow passing options to floating ui in plugin-tooltip #1436

Open
2 tasks done
edtownend opened this issue Jul 19, 2024 · 2 comments
Open
2 tasks done

[Feature] Allow passing options to floating ui in plugin-tooltip #1436

edtownend opened this issue Jul 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@edtownend
Copy link

Initial checklist

  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Problem

Since moving from tippy to floating ui the only option that can be passed to floading ui is the offset parameter. For my specific use case I'd like to provide a custom value to placement (which is now hardcoded to 'top') but I could imagine other users might have other options. Thanks for considering this!

Solution

Extend TooltipProviderOptions with a floatingUIOptions parameter similar to the tippyOptions parameter that came before

Alternatives

Also select options such as placement could be added direct to TooltipProviderOptions

@edtownend edtownend added the enhancement New feature or request label Jul 19, 2024
@Saul-Mirone
Copy link
Member

Good point

@3CordGuy
Copy link

This was a big oversight. I'm really surprised there would be this hard switch to a different dependency without exposing more config. It renders the tooltip very un-customizable in it's current form.

However I was able to get around it for now by building out a copy of the internal version of the TooltipProvider and just referencing that when constructing it with new TooltipProvider().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants