-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PySR should check SymbolicRegression.jl version #203
Comments
Why don't you check the version using |
They are only adding it to Julia 1.9: JuliaLang/julia#45607. For LTS versions I think I need this constant parameter. What do you think? |
Hmm, how long has |
Here’s the current approach: https://github.com/MilesCranmer/SymbolicRegression.jl/blob/cce9fda3d1fc6493b9d41ee92c6c630cb1944b95/src/SymbolicRegression.jl#L114. I guess the question is whether you’d want to do this inside PySR or SymbolicRegression.jl (and then just check the constant). |
I'd be tempted to suggest this should be checked on the python side, since Julia already has its ways of dealing with version requirements. |
Implemented a while back so closing. Cheers! |
SymbolicRegression.jl now has a
PACKAGE_VERSION
constant – this should be used by PySR to verify that the correct version is being imported. In practice, this probably not needed since PySR is managing the installs, but a user might have SymbolicRegression.jl installed in their base env, which might get imported instead. better to verify the version explicitly.The text was updated successfully, but these errors were encountered: