Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem/Bug]: MSEdgeWebView2 crashes when trying to preview a file through Monaco in file explorer using PowerToys #4228

Closed
Kosmit147 opened this issue Dec 12, 2023 · 4 comments
Assignees
Labels
bug Something isn't working regression Something used to work but doesn't anymore tracked We are tracking this work internally.

Comments

@Kosmit147
Copy link

Kosmit147 commented Dec 12, 2023

What happened?

The issue only occurs, when clicking on a file to preview it in file explorer. In that case msedgewebview2.exe crashes. If i run PowerToys.MonacoPreviewHandler.exe manually and supply the appropriate explorer window handle through the command line, the preview pane works correctly (you might need to click at the file in explorer again for the preview to appear). For example this command works for me: ""C:\ProgramFiles\PowerToys\PowerToys.MonacoPreviewHandler.exe" "C:\Users\wwojt\Desktop\Dev\Helium\LICENSE.txt" 0000000000320D0C 0 537 0 701").

PowerToysReport_2023-12-11-23-25-27.zip
f67b114d-8fa9-476a-9c9c-56c4ecb2f415.dmp

I attached a crash dump generated by msedgewebview.

Importance

Important. My app's user experience is significantly compromised.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

120.0.2210.61

SDK Version

No response

Framework

Other

Operating System

Windows 11

OS Version

10.0.22631

Repro steps

✔️ Expected Behavior
Expected to see a preview of a .txt file in the preview pane opened in monaco editor.

❌ Actual Behavior
Saw a loading bar, then preview pane just became empty.

Repros in Edge Browser

Not Applicable

Regression

Regression in newer Runtime

Last working version (if regression)

No response

AB#48141020

@Kosmit147 Kosmit147 added the bug Something isn't working label Dec 12, 2023
@lflores-ms lflores-ms added tracked We are tracking this work internally. regression Something used to work but doesn't anymore labels Dec 12, 2023
@vbryh-msft
Copy link
Contributor

Thank you for reporting the issue! We are working on the fix. Meanwhile the workaround is to use --disable-features=RendererAppContainer

@monica-ch
Copy link
Contributor

@Kosmit147 This is fixed in Edge Canary 121.0.2277.0+. Can you validate and confirm that the fix is working. Thanks!

https://learn.microsoft.com/en-us/microsoft-edge/webview2/how-to/set-preview-channel

@monica-ch
Copy link
Contributor

@Kosmit147 The fix was backported to 120.0.2210.77+ which started rolling out yesterday and reach all machines in next 36 hours. Please give a try and let us know if you still see the issue. Thanks!

@Kosmit147
Copy link
Author

@Kosmit147 The fix was backported to 120.0.2210.77+ which started rolling out yesterday and reach all machines in next 36 hours. Please give a try and let us know if you still see the issue. Thanks!

Can confirm the issue was fixed! Sorry for late reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something used to work but doesn't anymore tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

4 participants