Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the ListDetailsView doc #304

Closed
wants to merge 1 commit into from
Closed

Updated the ListDetailsView doc #304

wants to merge 1 commit into from

Conversation

COM8
Copy link
Contributor

@COM8 COM8 commented Mar 18, 2020

  • Added all new properties
  • Added a Windows 10X section

Related PR: CommunityToolkit/WindowsCommunityToolkit#3173

@COM8 COM8 changed the title Updated the MasterDetailsView docu [WIP] Updated the MasterDetailsView docu Mar 18, 2020
@opbld30
Copy link

opbld30 commented Mar 18, 2020

Docs Build status updates of commit 738855e:

🕙 Full build: the average full build time is 5 min(s) 36 sec(s), this is based on the last 13 build(s) for this repository.

⚠️ This is a FULL build due to the 'master' branch being a new branch in Docs Build service and is still building, or there are build errors in 'master' branch so the cache for incremental build is not available. Normally no action is required on your part, but if the full build persists, please contact your repository admin to manually perform a full build on the 'master' branch. For more detailed info, please click here.

@michael-hawker michael-hawker added this to the 6.1 milestone May 27, 2020
@Kyaa-dost
Copy link
Contributor

@COM8 can you please try updating the master into your own branch? Should fix the preview.

@michael-hawker michael-hawker removed this from the 6.1 milestone Jun 3, 2020
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld34 Jun 3, 2020
@michael-hawker
Copy link
Collaborator

Right, this feature is on hold until we figure out the WinUI story around here, moving this out of the 6.1 release for docs.

@opbld30
Copy link

opbld30 commented Jun 4, 2020

Docs Build status updates of commit 0b995e6:

✅ Validation status: passed

File Status Preview URL Details
docs/controls/MasterDetailsView.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Jun 4, 2020

Docs Build status updates of commit 08e065e:

✅ Validation status: passed

File Status Preview URL Details
docs/controls/MasterDetailsView.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@COM8 COM8 changed the title [WIP] Updated the MasterDetailsView docu Updated the MasterDetailsView docu Jun 4, 2020
@COM8
Copy link
Contributor Author

COM8 commented Jun 4, 2020

Updated it to master, so it is ready when it is needed :)

* Added all new properties
* Started working on the Windows 10X section
@opbld31
Copy link

opbld31 commented Aug 15, 2021

Docs Build status updates of commit d782da0:

✅ Validation status: passed

File Status Preview URL Details
docs/controls/MasterDetailsView.md 💡Suggestion View Details

docs/controls/MasterDetailsView.md

  • Line 34, Column 5: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.controls.masterdetailsview' will be broken in isolated environments. Replace with a relative link.
  • Line 36, Column 31: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/windows/uwp/design/controls-and-patterns/two-pane-view' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@michael-hawker michael-hawker changed the title Updated the MasterDetailsView docu Updated the ListDetailsView doc Aug 17, 2021
@michael-hawker
Copy link
Collaborator

@COM8 thanks for the update, can you create a branch for the doc and base it off the dev/7.1.0 branch? Weird things happen from forks going across main branches.

Also:

  • The control is now called the ListDetailsView (we need to update the filename with a redirect still)
  • We shouldn't call out Windows 10X as it was cancelled

@COM8
Copy link
Contributor Author

COM8 commented Aug 23, 2021

Closing in favor of #559

@COM8 COM8 closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants