Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark about the new Terminal app not supporting this function #159

Closed
aziascreations opened this issue Sep 10, 2020 · 2 comments
Closed

Comments

@aziascreations
Copy link

I think a remark about the fact that the new Terminal app doesn't and won't support any font related functions should be added somewhere in the documentation.

I recently tried using this function with no success, even tho it should have worked according to the documentation.
I then made an issue on the project's repo (microsoft/terminal#7585)
And I was told that it won't be supported by design (microsoft/terminal#6832 (comment))

Adding just a little line in the remarks section about this would help a lot in these types of issues.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@aziascreations aziascreations changed the title Add mention about the new Terminal app not supporting this function Add remark about the new Terminal app not supporting this function Sep 10, 2020
@miniksa
Copy link
Collaborator

miniksa commented Sep 10, 2020

That's a great call and I'll try to find time in the next pass of console docs to call out how the original console and Terminal are and will be different.

@miniksa
Copy link
Collaborator

miniksa commented Oct 29, 2020

I think #162 covers this.

I've added:

  • A banner at the top saying that this API is generally not recommended
    • This banner links to a page talking about classic console APIs vs VT and why we're favoring VT
    • It also links to a roadmap talking about where the console came from and where we're going toward with the Terminal
  • A banner in the remarks section that describes why this API is not recommended as it has no Virtual Terminal equivalent which makes it nigh impossible to remote properly and mesh with the other platforms and ecosystems where terminals are the norm.

If you don't think that's sufficient, please let me know with a further comment. The doc content should go live today/tomorrow and is visible in our main branch right now.

@miniksa miniksa closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants