Inconsistent shortcut key translations in menu vs workbench

[vsccarl]

• VSCode Version: 0.10.12-alpha
• OS Version: Windows 10 / Ubuntu 15.10

Steps to Reproduce:

1. Change to another language, I used Spanish.
2. Hover over the Explorer/Search/Git/Debug icons on the left

Actual:
It is translating the shortcut word Shift. Elsewhere, such as the file menu, it is not translated.

[dbaeumer]

@johnliu2016 can you please forward to the translation team.

[johnliu369]

@dbaeumer forwarded to loc team

[dbaeumer]

Thanks!

[johnliu369]

loc team says all instances of "Shift" are localized well, after all if we still see unlocalized "Shift", this probably implies localizability issue.
@vsccarl can you attach a s/s of the untranslated "Shift" of the file menu.

[vsccarl]

@johnliu2016

[johnliu369]

@dbaeumer can you help understand the shortcut accelerator of key combination display on such main menu, we found no single matching case in loc files

[dbaeumer]

@bpasero @alexandrudima I looked at the code and it looks like the resolving of a key binding to a user presentable string is done in keytCodes.ts and none of the code there is externalized (ElectronAcceleratorLabelProvider). Is this in oversight ?

[bpasero]

I do not think we control how Electron presents the key bindings in the menus.

[alexdima]

ElectronAcceleratorLabelProvider correctly does not use nls localize because these strings are passed to electron which then parses them:

https://github.com/electron/electron/blob/e05804848f98959d63337aacd9047cd579c5b23f/atom/common/keyboard_util.cc#L86

// Return key code represented by |str|.
ui::KeyboardCode KeyboardCodeFromKeyIdentifier(const std::string& s,
                                               bool* shifted) {
  std::string str = base::ToLowerASCII(s);
  if (str == "ctrl" || str == "control") {
    return ui::VKEY_CONTROL;
  } else if (str == "super" || str == "cmd" || str == "command" ||
             str == "meta") {
    return ui::VKEY_COMMAND;
  } else if (str == "commandorcontrol" || str == "cmdorctrl") {
#if defined(OS_MACOSX)
    return ui::VKEY_COMMAND;
#else
    return ui::VKEY_CONTROL;
#endif
  } else if (str == "alt" || str == "option") {
    return ui::VKEY_MENU;
  } else if (str == "shift") {
    return ui::VKEY_SHIFT;
  }

it is then Electron that renders them in the top level menu without any control from our side.

[bpasero]

I think we have to distinguish between Electron menu and hover: In the hover imho we can provide translated labels, for Electron we should follow up with them. I found electron/electron#1632 though I cannot remember we talked to them about this?

[bpasero]

I reopened electron/electron#1632. I can reproduce the issue on Windows, but interestingly not on Linux.

[bpasero]

We will change to custom menus on Windows. For now you can set "window.titleBarStyle": "custom".