Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support global application menu in Ubuntu 17.10 #36667

Closed
ilyahoilik opened this issue Oct 21, 2017 · 4 comments
Closed

Support global application menu in Ubuntu 17.10 #36667

ilyahoilik opened this issue Oct 21, 2017 · 4 comments
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality info-needed Issue requires more information from poster linux Issues with VS Code on Linux menus Menu items and widget issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@ilyahoilik
Copy link

ilyahoilik commented Oct 21, 2017 •
edited
Loading

Ubuntu 17.10 now uses GNOME instead of Unity.

I think it is better to move menu items from the menu bar to the GNOME application menu.
https://developer.gnome.org/hig/stable/patterns.html.en
https://developer.gnome.org/hig/stable/application-menus.html.en

It can help us to save a lot of work space.
@vscodebot vscodebot bot added the workbench label Oct 21, 2017
@bpasero bpasero added the feature-request Request for new features or functionality label Oct 22, 2017
@bpasero bpasero removed their assignment Oct 22, 2017
@bpasero bpasero added the linux Issues with VS Code on Linux label Oct 22, 2017
@ZanderBrown
Copy link

#39511 is relevant here

@sbatten sbatten mentioned this issue May 10, 2018
Closed
@Tyriar Tyriar mentioned this issue Jun 26, 2018
Closed
@bpasero bpasero changed the title Application menu in Ubuntu 17.10 Support global application menu in Ubuntu 17.10 Sep 19, 2018
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Sep 19, 2018
@sbatten sbatten added menus Menu items and widget issues and removed workbench-menu labels Oct 7, 2019
@bpasero
Copy link
Member

bpasero commented Oct 10, 2019

@ilyahoilik can I ask you to report this against Electron?

@bpasero bpasero added the info-needed Issue requires more information from poster label Oct 10, 2019
@ZanderBrown
Copy link

GNOME has actually dropped that menu now so this issue is somewhat defunct

Still need a symbolic icon for the app menu's replacement and high contrast modes though

@bpasero bpasero closed this as completed Oct 16, 2019
@bpasero
Copy link
Member

bpasero commented Oct 16, 2019

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to the code. As such, I will go ahead and close it. If you can identify the component that is causing the issue, please report it upstream:

Thanks for understanding.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality info-needed Issue requires more information from poster linux Issues with VS Code on Linux menus Menu items and widget issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bpasero @sbatten @ilyahoilik @ZanderBrown