Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How I can rename my theme extension #25988

Closed
Binaryify opened this issue May 5, 2017 · 1 comment
Closed

How I can rename my theme extension #25988

Binaryify opened this issue May 5, 2017 · 1 comment
Assignees

Comments

@Binaryify
Copy link

Hey, I am the 'OneDark-Pro' theme author, I rename this theme from 'Material Theme' to 'OneDark-Pro' recently.
image

I change the 'package.json' info
image

However, if I change the 'name', it will publish with a new theme and lose the downloads, if I don't change the 'name', the market site will show "ext install Material-theme"
image

What should I do now?

@seanmcbreen
Copy link

Hi sorry I just saw this

The ID for an extension is publishername.extensionname all meta data hangs off this e.g. downloads, ratings. This is also used for install/updates.

In this case I actually think most users would expect this to be a new extension i.e. it's pretty different from Material.

So I think publishing with a new ID would make the most sense - otherwise users will get updated and not understand that this is actually a different theme.

We don't have support for renaming today - so choosing a new name is typically something people only do in the display name or again they are forced to re-publish :(

Sean

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants