-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility:MAS13:Menus and context menu are not zooming in with the rest of the UI #17180
Comments
Title has been changed to a common format to perform data population. |
@sbatten I noticed that you prevent zooming of the menu, maybe we should revisit that decision based on this issue. |
@bpasero I agree we need to discuss this one. Currently, menus that aren't part of the menubar will zoom, while those associated with the menubar and the menubar itself will not. If we wanted to support this, I think we would need to send the menubar to its own row (its original position) either when zooming or as a setting which would then allow zooming. |
Or we have a maximum zoom level for it, if space is a problem? |
@bpasero could work although the limit may be too little? |
@sbatten did you try keeping the menu on the same line, is that not working with zooming? |
@bpasero the first option is keeping it on with zooming. That is about the limit on the amount of zooming before it looks weird...er |
@sbatten got it, yeah I would go with that. Why is the limit "too little", because the entire title div does not enlarge? |
@bpasero yes, in the first one, that's about as large as you can get it without making the titlebar bigger or cutting off the text so if you rely on zoom it might be too small. |
@sbatten what about allowing to zoom in the entire title div if the custom menu is enabled? |
@bpasero here is what that looks like if I understand you correctly. The controls and app icon look the weirdest. (edge in background for reference) |
@sbatten seems OK'ish to me, maybe make a branch or PR for me to play with? |
VS Code Version:1.6.1
OS Version:1607
Pre-Requisite:
1.Open visual studio code editor.
2.Using "Ctrl+" key repeatedly To Zoom to the Maximum
Steps to Reproduce:
Scenario 1:
1.Open visual studio code editor.
2.Observe the Menu Bar Visually on Zoom
Scenario 2:
Scenario 3:
Expected Result:
Scenario 1:
Menu Bar and options under Menu Bar should Adapt the Zoom feature of VS Code Editor
Scenario 2:
Icons under More in Git Repository side bar should Adapt the Zoom feature of VS Code Editor
Scenario 3:
Icons under More in Extensions side bar should Adapt the Zoom feature of VS Code Editor
Actual Result:
Scenario 1:
Menu Bar and options under Menu Bar is not adapting the Zoom feature of VS Code Editor
Scenario 2:
Icons under More in Git Repository side bar are not Adapting the Zoom feature of VS Code Editor
Scenario 3:
Options under More in Extensions side bar are not Adapting the Zoom feature of VS Code Editor
User Impact:
Low Vision users will not be able to clearly view these options as they are not adapting the Zoom feature of the application
The text was updated successfully, but these errors were encountered: