Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility:MAS13:Menus and context menu are not zooming in with the rest of the UI #17180

Closed
WiproPSAccTest opened this issue Dec 14, 2016 · 12 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@WiproPSAccTest
Copy link

VS Code Version:1.6.1
OS Version:1607
Pre-Requisite:
1.Open visual studio code editor.
2.Using "Ctrl+" key repeatedly To Zoom to the Maximum

Steps to Reproduce:
Scenario 1:
1.Open visual studio code editor.
2.Observe the Menu Bar Visually on Zoom
Scenario 2:

  1. Open visual studio code editor.
  2. Hit "Ctrl+Shift+G" to view the Git side bar and Navigate to more button and Hit Enter.
  3. Observe the options under More button on Zoom
    Scenario 3:
  4. Open visual studio code editor.
  5. Hit "Ctrl+Shift+X" to view the Extensions side bar and Navigate to more button and Hit Enter.
  6. Observe the options under More button on Zoom.

Expected Result:
Scenario 1:
Menu Bar and options under Menu Bar should Adapt the Zoom feature of VS Code Editor
Scenario 2:
Icons under More in Git Repository side bar should Adapt the Zoom feature of VS Code Editor
Scenario 3:
Icons under More in Extensions side bar should Adapt the Zoom feature of VS Code Editor

Actual Result:
Scenario 1:
Menu Bar and options under Menu Bar is not adapting the Zoom feature of VS Code Editor
Scenario 2:
Icons under More in Git Repository side bar are not Adapting the Zoom feature of VS Code Editor
Scenario 3:
Options under More in Extensions side bar are not Adapting the Zoom feature of VS Code Editor

User Impact:
Low Vision users will not be able to clearly view these options as they are not adapting the Zoom feature of the application

scenario 1_menu bar and options under menu bar are not adapting the zoom feature of vs code editor
scenario 2_options under more button in git side bar is not adapting the zoom feature of vs code editor
scenario 3_options under more button in extensions side bar is not adapting the zoom feature of vs code editor

@kieferrm kieferrm added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Dec 14, 2016
@bpasero bpasero changed the title Accessibility: Menu Bar and options under Menu Bar and options under More in Extensions and Git Repository side bar are not Adapting the Zoom feature of VS Code Editor. Menus and context menu are not zooming in with the rest of the UI Dec 15, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 15, 2016
@bpasero bpasero added this to the Backlog milestone Dec 15, 2016
@WiproPSAccTest WiproPSAccTest changed the title Menus and context menu are not zooming in with the rest of the UI Accessibility:MAS13:Menus and context menu are not zooming in with the rest of the UI Feb 1, 2017
@WiproPSAccTest
Copy link
Author

Title has been changed to a common format to perform data population.

@bpasero bpasero added workbench bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2017
@bpasero bpasero added the menu label May 26, 2017
@bpasero bpasero removed the workbench label Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 16, 2017
@bpasero
Copy link
Member

bpasero commented Jul 5, 2018

@sbatten I noticed that you prevent zooming of the menu, maybe we should revisit that decision based on this issue.

@sbatten sbatten added this to the July 2018 milestone Jul 5, 2018
@sbatten
Copy link
Member

sbatten commented Jul 5, 2018

@bpasero I agree we need to discuss this one. Currently, menus that aren't part of the menubar will zoom, while those associated with the menubar and the menubar itself will not. If we wanted to support this, I think we would need to send the menubar to its own row (its original position) either when zooming or as a setting which would then allow zooming.

@bpasero
Copy link
Member

bpasero commented Jul 6, 2018

If we wanted to support this, I think we would need to send the menubar to its own row

Or we have a maximum zoom level for it, if space is a problem?

@bpasero bpasero removed their assignment Jul 6, 2018
@sbatten
Copy link
Member

sbatten commented Jul 9, 2018

@bpasero could work although the limit may be too little?
image

default zoom
image

on new line
image

with editor color
image

@bpasero
Copy link
Member

bpasero commented Jul 10, 2018

@sbatten did you try keeping the menu on the same line, is that not working with zooming?

@sbatten
Copy link
Member

sbatten commented Jul 10, 2018

@bpasero the first option is keeping it on with zooming. That is about the limit on the amount of zooming before it looks weird...er

@bpasero
Copy link
Member

bpasero commented Jul 11, 2018

@sbatten got it, yeah I would go with that. Why is the limit "too little", because the entire title div does not enlarge?

@sbatten
Copy link
Member

sbatten commented Jul 11, 2018

@bpasero yes, in the first one, that's about as large as you can get it without making the titlebar bigger or cutting off the text so if you rely on zoom it might be too small.

@bpasero
Copy link
Member

bpasero commented Jul 12, 2018

@sbatten what about allowing to zoom in the entire title div if the custom menu is enabled?

@sbatten
Copy link
Member

sbatten commented Jul 12, 2018

@bpasero here is what that looks like if I understand you correctly. The controls and app icon look the weirdest. (edge in background for reference)
image

@bpasero
Copy link
Member

bpasero commented Jul 13, 2018

@sbatten seems OK'ish to me, maybe make a branch or PR for me to play with?

@sbatten sbatten closed this as completed Jul 27, 2018
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Aug 3, 2018
@mjbvz mjbvz added the verified Verification succeeded label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 10, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 3, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

8 participants