Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility:MAS42A:Menus and context menu are not adapting to high contrast theme #17177

Closed
WiproPSAccTest opened this issue Dec 14, 2016 · 3 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@WiproPSAccTest
Copy link

VS Code Version:1.6.1
OS Version:1607

Pre-Requisite:
1.Open visual studio code editor.
2.Using "Ctrl+Shift+P" key Open the command Pallete.
3.Type Theme, Navigate to Preferences: Color Theme and Hit Enter.
4.Navigate to High Contrast and Hit Enter.

Steps to Reproduce:

Scenario 1:
1.Open visual studio code editor.
2.Observe the Menu Bar Visually
Scenario 2:

  1. Open visual studio code editor.
  2. Hit "Ctrl+Shift+G" to view the Git side bar and Navigate to more button and Hit Enter.
  3. Observe the options under More button in High Contrast Theme
    Scenario 3:
  4. Open visual studio code editor.
  5. Hit "Ctrl+Shift+X" to view the Extensions side bar and Navigate to more button and Hit Enter.
  6. Observe the options under More button in High Contrast Theme.

Expected Result:
Scenario 1:
Menu Bar and options under Menu Bar should Adapt the High Contrast Theme of VS Code Editor
Scenario 2:
Icons under More in Git Repository side bar should Adapt the High Contrast Theme of VS Code Editor
Scenario 3:
Icons under More in Extension Repository side bar should Adapt the High Contrast Theme of VS Code Editor.

Actual Result:
Scenario 1:
Issue 1: Menu Bar and options under Menu Bar is not Adapting the High Contrast Theme
Observation: While using OS High Contrast Black Theme, Menu Bar is Partially adapting the OS High Contrast Theme. Issue here is Focused Sub Menu is not Highlighted according to the High Contrast Black Theme
Scenario 2:
Options under More in Git Repository side bar are not Adapting the High Contrast Theme of VS Code Editor
Scenario 3:
Options under More in Extensions side bar are not Adapting the High Contrast Theme of VS Code Editor

User Impact:
Low Vision users will not be able to clearly view the options under Menu Bar as it's not adapting the High Contrast Theme.

scenario 1_ menu bar and options under menu bar are not fully adapting the high contrast black theme of windows
scenario 1_ menu bar and options under menu bar is not adapting the high contrast theme of vs code editor
scenario 2_options under more button in extensions side bar is not adapting the high contrast theme of vs code editor
scenario 2_options under more button in git side bar is not adapting the high contrast theme of vs code editor

@kieferrm kieferrm added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Dec 14, 2016
@bpasero bpasero changed the title Accessibility: Menu Bar and options under Menu Bar and options under More in Extensions and Git Repository side bar are not Adapting the High Contrast Theme of VS Code Editor. Menus and context menu are not adapting to high contrast theme Dec 15, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 15, 2016
@bpasero bpasero added this to the Backlog milestone Dec 15, 2016
@WiproPSAccTest WiproPSAccTest changed the title Menus and context menu are not adapting to high contrast theme Accessibility:MAS42A:Menus and context menu are not adapting to high contrast theme Feb 1, 2017
@WiproPSAccTest
Copy link
Author

Title has been changed to a common format to perform data population.

@bpasero bpasero added the electron Issues and items related to Electron label Mar 8, 2017
@bpasero bpasero added workbench bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2017
@bpasero bpasero added the menu label May 26, 2017
@bpasero bpasero removed the workbench label Nov 12, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 16, 2017
@bpasero
Copy link
Member

bpasero commented Jul 5, 2018

We should support this with the new custom menu implementation.

@sbatten sbatten added this to the July 2018 milestone Jul 5, 2018
@sbatten
Copy link
Member

sbatten commented Jul 5, 2018

@bpasero I think we can consider this complete now.

@sbatten sbatten closed this as completed Jul 5, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jul 16, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 19, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 3, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

7 participants