Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change the background color of menu bar (Windows & some Linux) #16363

Closed
be5invis opened this issue Dec 2, 2016 · 26 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues

Comments

@be5invis
Copy link
Contributor

be5invis commented Dec 2, 2016

The menu bar is inconsistent with the dark theme in particular.

@chrmarti chrmarti added feature-request Request for new features or functionality workbench labels Dec 2, 2016
@bpasero bpasero removed their assignment Dec 3, 2016
@bpasero bpasero changed the title Give ability to change the background color of menu bar (Windows & some Linux) Allow to change the background color of menu bar (Windows & some Linux) Dec 3, 2016
@martinsuchan
Copy link

To get the idea, Visual Studio Code is at the top, full Visual Studio 2015 at the bottom.
aa8ea206-f2ac-11e6-8cd9-650d4ed5e722
d6f54dae-f2ac-11e6-9cc5-73524b61eb7d

@Stanzilla
Copy link

Those would have to be rewritten in JS then and the default Windows controls hidden

@Riajyuu
Copy link

Riajyuu commented Aug 15, 2017

Totally agreed with @be5invis

@jens1o
Copy link
Contributor

jens1o commented Aug 15, 2017

Question: Why this issue hasn't a milestone included?

@Riajyuu
Copy link

Riajyuu commented Aug 15, 2017

I guess they haven't look into this yet

@martinsuchan
Copy link

martinsuchan commented Aug 15, 2017

Electron runs inside standard Windows window. There is a Win32 API for changing window colors and fonts. I think the discussion should not be "is it possible?" but rather "how to do it".

@tjvf
Copy link

tjvf commented Sep 4, 2017

The issue is the menu bar (File, Edit, Selection, ...), which is provided by Electron, not the title bar, provided by Windows.

See this Electron issue, which shows it isn't directly possible at the moment. The suggestion is to re-implement the menu bar.

@mrmckeb
Copy link

mrmckeb commented Dec 2, 2017

It might make sense to re-implement the menu bar for Windows. With upcoming "Sets" feature in Windows 10, a custom menu would make VSCode look very clean in that environment.

@1st
Copy link

1st commented Dec 3, 2017

For MacOS it's implemented for atom/atom#11790 already. Can you back-port this change to VSCode?

@mjkramer
Copy link

mjkramer commented Feb 8, 2018

On Linux, this should be fixed by the upcoming Electron 1.9, which will be based on Chromium 61 + GTK3. See electron/electron#10213 and electron/electron#10836.

@jcklpe
Copy link

jcklpe commented May 27, 2018

Just wanted to add that I would like to see this change made also.

@Benjmhart
Copy link

+1 for making this chnge

@jrnail23
Copy link

I was referred here from Make it easier to distinguish between multiple VS Code windows #51710...

in case anyone else comes across this issue, the following (in my workspace settings file) did exactly what I wanted:

{
	"workbench.colorCustomizations": {
		"statusBar.background": "#666666",
		"sideBar.background": "#444444"
	}
}

Here are the docs for those color customizations: https://code.visualstudio.com/docs/getstarted/theme-color-reference

@teejayen
Copy link

teejayen commented Jun 30, 2018

Using a custom colour in Windows 10 and selecting to show the accent colour on Title bars will achieve the desired result.

@jcklpe
Copy link

jcklpe commented Jun 30, 2018 via email

@teejayen
Copy link

teejayen commented Jun 30, 2018

@thedonquixotic, my mistake.. should have read the thread more thoroughly. Dare I suggest hiding it, and toggling using Alt.

@jcklpe
Copy link

jcklpe commented Jul 2, 2018

Hey guys, I think I might actually have a solution though this might be a bad suggestion on my part.

I've recently been fiddling around with editing the Windows theme using registry editing. It's.... probably not super recommended, and I can't tell you how right at this moment (uh... because in the process I also totally borked my install of Windows 10), but from what I've been learning (or breaking) recently it should be possible, and relatively easy to put into a bat script. I'll let you guys know when I figure more out.

@fl3x1324
Copy link

fl3x1324 commented Jul 3, 2018

If I'm not mistaken, dark/black windows forms/win32 controls are coming in a future release of Win10. Or are those the XAML ones, that come with UWP?

@mohouyizme
Copy link

@fl3x1324 Good news! but I think it's not enough since the menu bar colors should be customizable within the themes.

@emeryao
Copy link

emeryao commented Jul 4, 2018

Hey guys, take a look at what I just found 😝

{
  "window.titleBarStyle": "custom"
}

@mohouyizme
Copy link

@emeryao It's available just in insiders version, hope it will be available in the next stable update, although it still needs some work.

@Evolveye
Copy link

Evolveye commented Jul 5, 2018

@mohouyizme You was right ^^
1.25 has it

@emeryao <3

@mohouyizme
Copy link

mohouyizme commented Jul 5, 2018

Good news 🤘🤘🤘! it's available now in the stable version which is 1.25.0.

untitled

as @emeryao reference, add this line to settings:

{
  "window.titleBarStyle": "custom"
}

@Merrit
Copy link

Merrit commented Jul 6, 2018

Just trying VS Code for the first time and fired up this option.. works/looks great! Cheers for implementing feedback 😃

@Wiredframe
Copy link

Really great to see that dark menu and title bar have been added, thanks! I just noticed that touch input doesn't work as expected in the menu. 😆

@Logerfo
Copy link
Contributor

Logerfo commented Aug 16, 2018

I use to hide native title bars on windows by unsetting the 0xC00000 flag. While the custom title bar is great by making both the menu bar and context menus follow the dark theme, it makes the title bar unhideable. I wish there was a mixed setting: use custom menus, but use the native title bar.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests