Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requirements.in (from pip-tools) #961

Merged
merged 4 commits into from
Mar 19, 2018
Merged

Add support for requirements.in (from pip-tools) #961

merged 4 commits into from
Mar 19, 2018

Conversation

lvillani
Copy link

@lvillani lvillani commented Mar 6, 2018

pip-tools provides a tool called pip-compile that takes a
requirements.in file with the same format used by requirements.txt to produce a "lock file"
(the usual requirements.txt file).

This commits enables the pip-requirements syntax for the aforementioned files.

@brettcannon brettcannon added this to the March 2018 milestone Mar 6, 2018
@brettcannon
Copy link
Member

Thanks for hte PR, @lvillani ! We are in code freeze for our next release, but we will look at this after we open the repo back up to feature work.

@brettcannon brettcannon self-requested a review March 12, 2018 18:11
@brettcannon brettcannon self-assigned this Mar 12, 2018
@codecov
Copy link

codecov bot commented Mar 12, 2018

Codecov Report

Merging #961 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   71.67%   71.89%   +0.21%     
==========================================
  Files         260      260              
  Lines       11877    11877              
  Branches     2104     2104              
==========================================
+ Hits         8513     8539      +26     
+ Misses       3239     3211      -28     
- Partials      125      127       +2
Impacted Files Coverage Δ
...rc/client/debugger/PythonProcessCallbackHandler.ts 51.64% <0%> (-1.32%) ⬇️
src/client/linters/baseLinter.ts 91.66% <0%> (+4.16%) ⬆️
src/client/common/installer/productInstaller.ts 64.55% <0%> (+4.23%) ⬆️
src/client/common/application/applicationShell.ts 30.76% <0%> (+7.69%) ⬆️
src/client/common/logger.ts 73.33% <0%> (+20%) ⬆️
src/client/linters/errorHandlers/errorHandler.ts 100% <0%> (+22.22%) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 94.44% <0%> (+61.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c924a...e6f6c26. Read the comment docs.

@brettcannon
Copy link
Member

FYI @lvillani the PR looks good, but I need to be in a position to add a news entry before I can merge (unless you want to add a news entry yourself 😁 ).

@lvillani
Copy link
Author

lvillani commented Mar 15, 2018

Hey @brettcannon, sure I can add the news entry myself. I'm unfamiliar with the process, do I have to create a file called 961.md in the 1 Enhancements directory?

@brettcannon
Copy link
Member

@lvillani https://github.com/Microsoft/vscode-python/blob/master/news/README.md should explain what to do (and if it doesn't please let me know as you're the first external contributor to do this 😁 ).

@msftclas
Copy link

msftclas commented Mar 16, 2018

CLA assistant check
All CLA requirements met.

lvillani and others added 3 commits March 16, 2018 19:30
[pip-tools](https://github.com/jazzband/pip-tools) provides a tool called `pip-compile` that takes a
`requirements.in` file with the same format used by `requirements.txt` to produce a "lock file"
(the usual `requirements.txt` file).

This commits enables the `pip-requirements` syntax for the aforementioned files.
@lvillani
Copy link
Author

lvillani commented Mar 16, 2018

@brettcannon I have added this file and rebased the branch against master. I can also squash all commits together if you want.

@brettcannon brettcannon merged commit 2f739ff into microsoft:master Mar 19, 2018
@brettcannon
Copy link
Member

Thanks, @lvillani !

@lvillani lvillani deleted the patch-1 branch March 27, 2018 11:10
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants