-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for requirements.in (from pip-tools) #961
Conversation
Thanks for hte PR, @lvillani ! We are in code freeze for our next release, but we will look at this after we open the repo back up to feature work. |
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 71.67% 71.89% +0.21%
==========================================
Files 260 260
Lines 11877 11877
Branches 2104 2104
==========================================
+ Hits 8513 8539 +26
+ Misses 3239 3211 -28
- Partials 125 127 +2
Continue to review full report at Codecov.
|
FYI @lvillani the PR looks good, but I need to be in a position to add a news entry before I can merge (unless you want to add a news entry yourself 😁 ). |
Hey @brettcannon, sure I can add the news entry myself. I'm unfamiliar with the process, do I have to create a file called |
@lvillani https://github.com/Microsoft/vscode-python/blob/master/news/README.md should explain what to do (and if it doesn't please let me know as you're the first external contributor to do this 😁 ). |
[pip-tools](https://github.com/jazzband/pip-tools) provides a tool called `pip-compile` that takes a `requirements.in` file with the same format used by `requirements.txt` to produce a "lock file" (the usual `requirements.txt` file). This commits enables the `pip-requirements` syntax for the aforementioned files.
@brettcannon I have added this file and rebased the branch against master. I can also squash all commits together if you want. |
Thanks, @lvillani ! |
pip-tools provides a tool called
pip-compile
that takes arequirements.in
file with the same format used byrequirements.txt
to produce a "lock file"(the usual
requirements.txt
file).This commits enables the
pip-requirements
syntax for the aforementioned files.