Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display name of interpreters to remove duplicate Python prefix #1651

Closed
DonJayamanne opened this issue May 10, 2018 · 3 comments · Fixed by #1652
Closed

Fix display name of interpreters to remove duplicate Python prefix #1651

DonJayamanne opened this issue May 10, 2018 · 3 comments · Fixed by #1652
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
May 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented May 10, 2018 •
edited
Loading

screen shot 2018-05-10 at 9 55 07 am
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels May 10, 2018
@DonJayamanne DonJayamanne added this to the May 2018 milestone May 10, 2018
@DonJayamanne DonJayamanne self-assigned this May 10, 2018
@DonJayamanne DonJayamanne mentioned this issue May 10, 2018
Merged
5 tasks
@d3r3kk
Copy link

d3r3kk commented May 28, 2018

Tried to repro this on Ubuntu 18.04 and Windows, but could not. However, the problem also was not manifesting on those two platforms using the Production version of VSCode and 2018.4.0 of the extension.

Is there a more specific repro case?

@DonJayamanne DonJayamanne changed the title Fix display name of interpreters to remote duplicate Python prefix Fix display name of interpreters to remove duplicate Python prefix May 28, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented May 28, 2018 •
edited
Loading

Hmm, possibly a Mac only issue. Will test tomorrow

@DonJayamanne
Copy link
Author

@d3r3kk
Interestingly I too cannot replicate the issue anymore.
Either way, I'm comfortable with the fix, as we have sufficient tests for the change.

@DonJayamanne DonJayamanne removed their assignment May 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Prefix display name with 'Python' only if not already prefixed DonJayamanne/pythonVSCode
3 participants
@brettcannon @DonJayamanne @d3r3kk