Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation isn't displayed in the start page #15232

Closed
FiftysixTimes7 opened this issue Jan 26, 2021 · 4 comments
Closed

Translation isn't displayed in the start page #15232

FiftysixTimes7 opened this issue Jan 26, 2021 · 4 comments
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release

Comments

@FiftysixTimes7
Copy link

FiftysixTimes7 commented Jan 26, 2021

Environment data

  • VS Code version: 1.52.1
  • Extension version (available under the Extensions sidebar): 2021.1.0
  • OS and version: Windows 10 (20H2)
  • Python version (& distribution if applicable, e.g. Anaconda): 3.9.1
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Relevant/affected Python packages and their versions: N/A
  • Relevant/affected Python-related VS Code extensions and their versions: N/A
  • Value of the python.languageServer setting: Jedi

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]

Expected behaviour

Start page is translated.

Actual behaviour

Start page is not translated.

Steps to reproduce:

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

  1. Use Simplified Chinese language. (Translated by Update Simplified Chinese translation #14997 )
  2. Open start page.

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

(If needed, it'll be filled in later.)

@FiftysixTimes7 FiftysixTimes7 added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Jan 26, 2021
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 26, 2021
@karthiknadig karthiknadig added the area-editor-* User-facing catch-all label Jan 26, 2021
@kimadeline
Copy link

Hi @FiftysixTimes7, thank you for reporting this issue!

Start page translations used to be loaded by initializeLoc in src/datascience-ui/data-explorer/mainPanel.tsx (see commit 2cb0ef2):

private initializeLoc(content: string) {
const locJSON = JSON.parse(content);
storeLocStrings(locJSON);
}

However when the Jupyter extension became its own repo it took this file method from vscode-python, and translations for the start page haven't been loaded since.

https://github.com/microsoft/vscode-jupyter/blob/fdd05ada958f3cc03f852b0d3dd428f0fe903964/src/datascience-ui/data-explorer/mainPanel.tsx#L166-L169

@kimadeline kimadeline added needs PR regression Bug didn't exist in a previous release and removed triage labels Jan 26, 2021
ericsnowcurrently added a commit that referenced this issue Feb 2, 2021
(for #15232)

Localization was accidentally disabled in #14447 (October) when we split out the Jupyter extension.
@FiftysixTimes7
Copy link
Author

屏幕截图 2021-02-20 112901

This line is still not translated?😂

@kimadeline
Copy link

Thank you for pointing it out, it should be createJupyterNotebook with a lowercase c on line 77:

<div className="block">
<div className="text" onClick={this.openBlankNotebook} role="button">
{getLocString('StartPage.CreateJupyterNotebook', 'Create a Jupyter Notebook')}
</div>
{this.renderNotebookDescription()}
</div>

It should be an easy PR if you're up for it 🙂

@FiftysixTimes7
Copy link
Author

Yeah, I fixed it in #15488 :) @kimadeline

@ghost ghost removed the needs PR label Feb 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

4 participants