Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest insiders program nor show start page when in codespaces #14833

Closed
luabud opened this issue Nov 26, 2020 · 2 comments · Fixed by #15244
Closed

Don't suggest insiders program nor show start page when in codespaces #14833

luabud opened this issue Nov 26, 2020 · 2 comments · Fixed by #15244
Assignees
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality important Issue identified as high-priority

Comments

@luabud
Copy link
Member

luabud commented Nov 26, 2020

Right now we show two separate prompts for the Jupyter and the Python extension insiders program, when we first see someone in VS Code Insiders. I'm wondering if we could display just one notification prompt to include users in both programs at once. Users would still be able to opt in to each program separately from extensions, this would be just to avoid over prompting notifications.


Update: changing this to drop the notifications when in a codespace, as well as the start page.

@luabud luabud added feature-request Request for new features or functionality needs decision area-editor-* User-facing catch-all labels Nov 26, 2020
@luabud
Copy link
Member Author

luabud commented Nov 26, 2020

FYI @claudiaregio @greazer

@aeschli
Copy link

aeschli commented Dec 3, 2020

Codespaces currently use Insider builds, and have the regular Python extension installed by default. Because of that, all Codespaces users see the notifications the first time a Python file is opened. That's confusing for new users.

I suggest to only recommend the insiders program to power users. Don't show the dialog on the first activation of the Python extension. Better wait for more advanced commands, or only recommend when a user has used the Python extension for a week or more.

@luabud luabud changed the title Suggest both Jupyter and Python insiders program when in VS Code Insiders Don't suggest insiders program when in codespaces Dec 18, 2020
@luabud luabud added the important Issue identified as high-priority label Dec 18, 2020
@luabud luabud changed the title Don't suggest insiders program when in codespaces Don't suggest insiders program nor show start page when in codespaces Dec 18, 2020
@ghost ghost removed the needs decision label Jan 27, 2021
@karrtikr karrtikr self-assigned this May 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants