Fix infinite loop when godef fails

microsoft · Jan 20, 2019 · 8c6f035 · 8c6f035
1 parent a7b0fb7
commit 8c6f035
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/goDeclaration.ts b/src/goDeclaration.ts
@@ -107,9 +107,10 @@ function definitionLocation_godef(input: GoDefinitionInput, token: vscode.Cancel
 				if (err) {
 					if (stderr.indexOf('flag provided but not defined: -r') !== -1) {
 						promptForUpdatingTool('godef');
+						p = null;
+						return definitionLocation_godef(input, token, false).then(resolve, reject);
 					}
-					p = null;
-					return definitionLocation_godef(input, token, false).then(resolve, reject);
+					return reject(err.message || stderr);
 				}
 				let result = stdout.toString();
 				let lines = result.split('\n');