This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Fix using deleted handles #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Feb 10, 2018
src/chrome/breakOnLoadHelper.ts
Outdated
| // If the file has unbound breakpoints, resolve them and return true | ||
| if (pendingBreakpoints !== undefined) { | ||
| await this._chromeDebugAdapter.resolvePendingBreakpoint(pendingBreakpoints); | ||
| this._chromeDebugAdapter.pendingBreakpointsByUrl.delete(source); | ||
| if (!this._chromeDebugAdapter.pendingBreakpointsByUrl.delete(normalizedSource)) { | ||
| logger.warn(`Expected to delete ${normalizedSource} from the list of pending breakpoints, but it wasn't there`); |
There was a problem hiding this comment.
Warnings appear to the user in the console, is that what you want? If so this should be written in terms the user will understand and tell them what to do about it.
There was a problem hiding this comment.
That wasn't my intention. I want this to appear in the log only. I'll change this to: logger.log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix we were sending the wrong filename, so the pending breakpoints weren't being deleted, so then after a refresh we tried to add them again, and they had associated old breakpoint handles that don't exist any more, causing issues for some clients