This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Enhance path matching #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check out the failing tests before you say that it doesn't introduce a regression 😁 Also it's not clear exactly what the change allows you to do. Please add some unit tests for new cases. |
|
Where can I find unit tests?
|
|
The unit tests are here - https://github.com/Microsoft/vscode-chrome-debug-core/blob/master/test/chrome/chromeUtils.test.ts#L92 - you can follow the pattern to add more cases. |
|
Thanks for the PR! |
digeff
pushed a commit
to digeff/vscode-chrome-debug-core
that referenced
this pull request
Jul 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to enhance path matching to simplify configuration. Will be able to match only a part of the url to map to a local path. This modification doesn't introduce regression. Tested locally