Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

sourceMapPathOverrides application order #297

Closed
roblourens opened this issue Mar 5, 2018 · 0 comments
Closed

sourceMapPathOverrides application order #297

roblourens opened this issue Mar 5, 2018 · 0 comments
Assignees
Milestone

Comments

@roblourens
Copy link
Member

I think this is mentioned in one or more issues but I don't believe it has it's own issue yet.

sourceMapPathOverrides was previously applied by key order within the object which is unintuitive. I am changing it to be applied by the length of the key. This not perfect, and we lose the flexibility of being able to arbitrarily order the keys, but I think it is more likely to be correct. I'll try it out and see what breaks.

If we need to return to key order, it should be an array rather than an object.

@roblourens roblourens added this to the March 2018 milestone Mar 5, 2018
@roblourens roblourens self-assigned this Mar 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant