Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Use getPossibleBreakpoints to support column bps, when supported #144

Closed
roblourens opened this issue Jan 2, 2017 · 1 comment
Closed

Use getPossibleBreakpoints to support column bps, when supported #144

roblourens opened this issue Jan 2, 2017 · 1 comment
Labels
enhancement
Milestone
April 2017

Comments

@roblourens
Copy link
Member

roblourens commented Jan 2, 2017 •
edited
Loading

https://chromedevtools.github.io/debugger-protocol-viewer/v8/Debugger/#method-getPossibleBreakpoints

I think when a BP is set at column x, need to call getPossibleBPs for line N, from column 0 to column x, and pick the last one.

If the runtime doesn't support that method, need to set the BP at column 0 (pre-sourcemapping)
@roblourens roblourens mentioned this issue Jan 2, 2017
Closed
@auchenberg
Copy link
Contributor

Nicely spotted. This API must be used by Chrome's new inline-breakpoints feature.

@auchenberg auchenberg modified the milestone: Backlog Jan 9, 2017
@auchenberg auchenberg modified the milestone: Backlog Jan 26, 2017
@roblourens roblourens modified the milestones: April 2017, Backlog Apr 17, 2017
roblourens added a commit that referenced this issue Apr 18, 2017
@roblourens
For #144 - Handle multiple BPs at one location
45fd24e
roblourens added a commit that referenced this issue Apr 18, 2017
@roblourens
#144 - detect getPossBreakpoints API support ahead of time
012a56f
@kieferrm kieferrm mentioned this issue Apr 21, 2017
Closed
15 tasks
@roblourens roblourens mentioned this issue Apr 22, 2017
Closed
1 task
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
2 participants
@auchenberg @roblourens