Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

proposed type-checking for noStringBased rules #417

Closed
wants to merge 1 commit into from

Conversation

tsmolka
Copy link
Contributor

@tsmolka tsmolka commented Feb 13, 2018

I experienced false positives in no-string-based-set-timeout rule when setTimeout is called on http.ClientRequest from module http.

In this PR I am proposing to add additional type checks so that such FPs are eliminated. Existing tests are successful but we might need to test this on larger code base.

@HamletDRC
Copy link
Member

I tested this on Microsoft Social Engagement codebase and it fixed a couple false positives we had. No errors that I saw.

@HamletDRC HamletDRC closed this in 231b944 Apr 16, 2018
@JoshuaKGoldberg JoshuaKGoldberg added this to the 5.0.4 milestone Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants