Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add tslint.json to npm release #190

Closed
tpetry opened this issue Aug 9, 2016 · 7 comments
Closed

Add tslint.json to npm release #190

tpetry opened this issue Aug 9, 2016 · 7 comments
Assignees
Milestone

Comments

@tpetry
Copy link

tpetry commented Aug 9, 2016

It would be really helpfully if the recommended tslint.json would be added to the npm release so build scripts could directly reference the tslint.json of the release instead of having to merge the actual version from github everytime to a local copy.

@HamletDRC
Copy link
Member

Do you want the file recommended_ruleset.js (which is a .js file?)
Or do you want the recommended_ruleset.js to be converted to JSON and copied as the file tslint.json?

@tpetry
Copy link
Author

tpetry commented Aug 9, 2016

The tslint.json. It is included in the normal release tags but not the release tags for npm.

@HamletDRC
Copy link
Member

HamletDRC commented Aug 9, 2016

I can put this in the deployment, but what do you want it for? It is just some rules that we use internally on the project and it is not how we recommend other projects be configured. It seems like what you actually want is recommended_ruleset.js.

@tpetry
Copy link
Author

tpetry commented Aug 9, 2016

Then maybe it would be better to convert it to recommened_ruleset.json for the npm release.

@HamletDRC
Copy link
Member

@HamletDRC
Copy link
Member

Here is the link to the recommended_ruleset.js
https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/recommended_ruleset.js

@HamletDRC
Copy link
Member

There are some tools that will see tslint.json and by default use that... so perhaps there is value in renaming the thing to tslint.json.

@HamletDRC HamletDRC added this to the 2.0.10 milestone Aug 11, 2016
@HamletDRC HamletDRC self-assigned this Aug 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants