This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 198
/
validTypeofRule.ts
130 lines (113 loc) · 5.17 KB
/
validTypeofRule.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
import * as ts from 'typescript';
import * as Lint from 'tslint';
import * as tsutils from 'tsutils';
import { ExtendedMetadata } from './utils/ExtendedMetadata';
export class Rule extends Lint.Rules.AbstractRule {
public static metadata: ExtendedMetadata = {
ruleName: 'valid-typeof',
type: 'maintainability',
description: 'Ensures that the results of typeof are compared against a valid string.',
options: null, // tslint:disable-line:no-null-keyword
optionsDescription: '',
typescriptOnly: true,
issueClass: 'Non-SDL',
issueType: 'Error',
severity: 'Critical',
level: 'Opportunity for Excellence',
recommendation: 'false,',
group: 'Deprecated'
};
public static FAILURE_STRING: string = 'Invalid comparison in typeof. Did you mean ';
public static VALID_TERMS: string[] = ['undefined', 'object', 'boolean', 'number', 'string', 'function', 'symbol'];
private static isWarningShown: boolean = false;
public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
if (Rule.isWarningShown === false) {
console.warn('Warning: valid-typeof rule is deprecated. Replace your usage with the TSLint typeof-compare rule.');
Rule.isWarningShown = true;
}
return this.applyWithFunction(sourceFile, walk);
}
}
function walk(ctx: Lint.WalkContext<void>) {
function getClosestTerm(term: string): string {
let closestMatch: number = 99999999;
return Rule.VALID_TERMS.reduce((closestTerm: string, thisTerm: string): string => {
const distance = levenshteinDistance(term, thisTerm);
if (distance < closestMatch) {
closestMatch = distance;
closestTerm = thisTerm;
}
return closestTerm;
}, '');
}
/**
Copyright (c) 2011 Andrei Mackenzie
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and
associated documentation files (the "Software"), to deal in the Software without restriction,
including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense,
and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial
portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT
LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
/**
* Inspired from: https://gist.github.com/andrei-m/982927
*/
/* tslint:disable:increment-decrement */
function levenshteinDistance(a: string, b: string): number {
if (a.length === 0) {
return b.length;
}
if (b.length === 0) {
return a.length;
}
const matrix = [];
// increment first column
for (let i = 0; i <= b.length; i++) {
matrix[i] = [i];
}
// increment first row
for (let i = 0; i <= a.length; i++) {
matrix[0][i] = i;
}
// populate matrix
for (let i = 1; i <= b.length; i++) {
for (let j = 1; j <= a.length; j++) {
if (b.charAt(i - 1) === a.charAt(j - 1)) {
matrix[i][j] = matrix[i - 1][j - 1];
} else {
const substitutionValue: number = matrix[i - 1][j - 1] + 1;
const insertionValue: number = matrix[i][j - 1] + 1;
const deletionDistance: number = matrix[i - 1][j] + 1;
const minDistance = Math.min(substitutionValue, insertionValue, deletionDistance);
matrix[i][j] = minDistance;
}
}
}
return matrix[b.length][a.length];
}
/* tslint:enable:increment-decrement */
function validateTypeOf(node: ts.StringLiteral): void {
if (Rule.VALID_TERMS.indexOf(node.text) === -1) {
const start: number = node.getStart();
const width: number = node.getWidth();
ctx.addFailureAt(start, width, Rule.FAILURE_STRING + getClosestTerm(node.text) + '?');
}
}
function cb(node: ts.Node): void {
if (tsutils.isBinaryExpression(node)) {
if (node.left.kind === ts.SyntaxKind.TypeOfExpression && node.right.kind === ts.SyntaxKind.StringLiteral) {
validateTypeOf(<ts.StringLiteral>node.right);
} else if (node.right.kind === ts.SyntaxKind.TypeOfExpression && node.left.kind === ts.SyntaxKind.StringLiteral) {
validateTypeOf(<ts.StringLiteral>node.left);
}
}
return ts.forEachChild(node, cb);
}
return ts.forEachChild(ctx.sourceFile, cb);
}