Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter is not sending TestCategory traits in testcase object to testhost. #189

Closed
Faizan2304 opened this issue May 24, 2017 · 4 comments
Closed

Adapter is not sending TestCategory traits in testcase object to testhost. #189

Faizan2304 opened this issue May 24, 2017 · 4 comments
Assignees
@jayaranigarg
Milestone
S120

Comments

@Faizan2304
Copy link
Contributor

From @antferreira

Description

.trx file generated by dotnet test don't have test categories information

Steps to reproduce

Create a test project with test methods annotated with [TestCategory("foo")].
Run dotnet test --logger "trx"

Expected behavior

.trx file with test categories information

Actual behavior

.trx file without test categories information

Environment

Windows 10 Pro 1607
MSTest.TestAdapter 1.1.17
MSTest.TestFramework 1.1.17
dotnet version 1.0.4
@Faizan2304 Faizan2304 mentioned this issue May 24, 2017
Closed
@AbhitejJohn AbhitejJohn modified the milestone: S119 May 28, 2017
@AbhitejJohn
Copy link
Contributor

This is working in VS IDE. Strange it isn't in trx. The adapter does not differentiate these two scenarios. Need to investigate this one.

@jayaranigarg
Copy link
Member

Platform searches for TestProperty in list of properties by Id. This Id has changed for MSTestV2. That is the reason neither TPV1 nor TPV2 are able to find TestCategory properties.
Changes need to be made in this part of code s.t. it does not check for any hard-coded category ID.

@jayaranigarg jayaranigarg modified the milestones: S120, S119 Jul 3, 2017
@codito
Copy link
Contributor

codito commented Jul 4, 2017

@jayaranigarg any idea why the id was changed for MSTestv2? Just curious..

@AbhitejJohn
Copy link
Contributor

@codito: Ah that was just to be consistent with the executor uri which has the v2 in it.

@jayaranigarg jayaranigarg mentioned this issue Jul 6, 2017
Merged
@jayaranigarg jayaranigarg self-assigned this Jul 10, 2017
singhsarab pushed a commit to singhsarab/testfx that referenced this issue Apr 8, 2019
@harshjain2
Updated version of TestHost package in Microsoft.NET.TestSdk.nuspec (m…
0ccc6f4 
…icrosoft#189)

* Updated version of TestHost package in Microsoft.NET.TestSdk.nuspec

* Updated title.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayaranigarg jayaranigarg

Labels
None yet
Projects
None yet
Milestone
S120
Development

No branches or pull requests
4 participants
@codito @jayaranigarg @AbhitejJohn @Faizan2304