Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Configure JSON defaults sample #731

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Conversation

apalm
Copy link
Contributor

@apalm apalm commented Feb 21, 2018

The Configure JSON defaults sample in the playground is currently broken. Validation errors never show up even when the JSON doesn't conform to the schema.

screen shot 2018-02-20 at 20 15 52

Here's what I had to change to get it to work:

I also changed the initial JSON so that the validation errors show up without editing the JSON.

Test Plan

Ran gulp simpleserver. The validation errors now show up as expected.

screen shot 2018-02-20 at 20 16 46

@msftclas
Copy link

msftclas commented Feb 21, 2018

CLA assistant check
All CLA requirements met.

@alexdima alexdima merged commit b900ebb into microsoft:master Mar 13, 2018
@alexdima
Copy link
Member

Thank you! 👍

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants