Add checks for non-ENU tf(.exe) #158

jeffyoung · 2017-03-20T22:49:02Z

(Reviewing by commit may be easier.)

French, German and Spanish all return version strings a bit differently. French and Spanish are quick outs. The German version string parses fine but when getting the workspace it can be detected.
Also moved the initialization of the SCM provider after we have valid credentials. If we don't, there's no sense in setting up the provider.

These are 3 of the supported tf (VS) languages and are all a bit different from each other.

jpricket · 2017-03-21T13:05:45Z

src/extensionmanager.ts

@@ -275,6 +275,14 @@ export class ExtensionManager implements Disposable {
                            }
                        }
                    }
+
+                    // Now that everything else is ready, create the SCM provider
+                    if (this._repoContext.Type === RepositoryType.TFVC && !this._scmProvider) {


This seems incorrect. The Reinit call will happen if the type != TFVC.

jpricket

There seems to be one bug. See comments

Jeff Young added 4 commits March 20, 2017 15:41

Remove optional settings

ae5897f

Add return type for CheckVersion

8e3544c

Check for non-ENU tf(.exe)

51e39d0

Add support for Spanish, French and German

ddf19cf

These are 3 of the supported tf (VS) languages and are all a bit different from each other.

msftclas added the cla-not-required label Mar 20, 2017

jpricket reviewed Mar 21, 2017

View reviewed changes

jpricket suggested changes Mar 21, 2017

View reviewed changes

Ensure initialize and reinitialize only occur for TFVC

087be02

jeffyoung merged commit 435bf91 into master Mar 21, 2017

jeffyoung deleted the jeyou/non-enu-tf branch March 21, 2017 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add checks for non-ENU tf(.exe) #158

Add checks for non-ENU tf(.exe) #158

jeffyoung commented Mar 20, 2017

jpricket Mar 21, 2017

jpricket left a comment

Add checks for non-ENU tf(.exe) #158

Add checks for non-ENU tf(.exe) #158

Conversation

jeffyoung commented Mar 20, 2017

jpricket Mar 21, 2017

Choose a reason for hiding this comment

jpricket left a comment

Choose a reason for hiding this comment