This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix up status command for tf.exe support #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add unit tests for coverage
jpricket
reviewed
Feb 23, 2017
src/tfvc/commands/status.ts
Outdated
| continue; | ||
| } | ||
|
|
||
| if (line.indexOf("--------") === 0 || line.toLowerCase().startsWith("detected changes: ")) { |
There was a problem hiding this comment.
seems like you could use startswith instead of indexOf === 0 here. It would make it a bit easier to read.
jpricket
reviewed
Feb 23, 2017
| case "change": return "changeType"; | ||
| case "workspace": return "workspace"; | ||
| } | ||
| return undefined; | ||
| } | ||
|
|
||
| private add(changes: IPendingChange[], newChange: IPendingChange, ignoreFolders: boolean) { |
There was a problem hiding this comment.
Doesn't look like you are using add or convert at all
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add unit tests for coverage