chore(deps): upgrade dependencies #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrading dependencies to update minimist resolutions to use 1.2.5
devaradhanm
changed the title
dbjorge
reviewed
Apr 14, 2020
| @@ -2,144 +2,152 @@ | |||
| # yarn lockfile v1 | |||
|
|
|||
|
|
|||
| "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.5.5", "@babel/code-frame@^7.8.3": | |||
There was a problem hiding this comment.
Did you manually update yarn.lock to cover this? I thought that with yarn, the preferred pattern was to update package.json with a resolutions property to enable yarn to handle this itself; was that not an option here?
There was a problem hiding this comment.
I did not manually update yarn. I just deleted yarn.lock & did yarn install again to update all packages. That fixed the issue. Alternatively i could have also added resolution in package.json on npm to fix this issue. But, chose this option since we anyway try to be up to date with dependabot.
dbjorge
approved these changes
Apr 14, 2020
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
upgrading dependencies to update minimist resolutions to use 1.2.5 (upgrading npm from 6.13.6 to 6.14.4 fixes this issue, but i just upgraded all packages instead.)
1.2.0 version was used under node_modules/npm/node_modules/rc/node_modules/minimist/package.json
& 0.0.8 under /home/vsts/work/1/s/node_modules/npm/node_modules/minimist/package.json
Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE:yarn precheckin