Use PathTypeHandler's for function objects with non-default properties/attributes #4818
Conversation
pleath
force-pushed
the
funcpathtypes
branch
2 times, most recently
from
3411e00
to
24d7c5f
Compare
| @@ -135,6 +112,64 @@ namespace Js | |||
| return newTypeHandler; | |||
| } | |||
|
|
|||
| template<size_t size> | |||
| PathTypeHandlerBase* SimpleTypeHandler<size>::ConvertToPathType(DynamicObject* instance) | |||
There was a problem hiding this comment.
In one Speedometer test I saw a lot of SimpleTypeHandler::AddProperty/convert calls. This makes me think that SimpleTypeHandler type sharing isn't great (and so the PathTypeHandler sharing won't be great either). I'll try to find the case where this was happening, but I think there might be more to do here.
Is it the case that all function objects have their own SimpleTypeHandler?
There was a problem hiding this comment.
I'd like to see the code you're talking about. PathTypeHandler sharing will work in cases that SimpleTypeHandler doesn't -- basically, any case where we're changing the default properties/attributes of the object.
There was a problem hiding this comment.
Ah I see, this looks good! I'm excited to see the win we get!
|
@dotnet-bot test Windows ci_disablejit_x64_debug |
…s/attributes. Move from creating new non-shared SimpleTypeHandler's when a new property is added to a SimpleTypeHandler, or an attribute is changed, to creating PathTypeHandler's. Build a new root and evolve from the root to the current state of the SimpleTypeHandler, then replace the type's existing SimpleTypeHandler with the new PathTypeHandler. From there, we can evolve to the state required by the new property/attribute, and future instances of the same function that make the same type transition will get the same type. Also fix up some shared SimpleTypeHandler's in the library that didn't represent the desired state of their library objects and were forcing type transitions during initialization.
… non-default properties/attributes Merge pull request #4818 from pleath:funcpathtypes Move from creating new non-shared SimpleTypeHandler's when a new property is added to a SimpleTypeHandler, or an attribute is changed, to creating PathTypeHandler's. Build a new root and evolve from the root to the current state of the SimpleTypeHandler, then replace the type's existing SimpleTypeHandler with the new PathTypeHandler. From there, we can evolve to the state required by the new property/attribute, and future instances of the same function that make the same type transition will get the same type. Also fix up some shared SimpleTypeHandler's in the library that didn't represent the desired state of their library objects and were forcing type transitions during initialization.
Move from creating new non-shared SimpleTypeHandler's when a new property is added to a SimpleTypeHandler, or an attribute is changed, to creating PathTypeHandler's. Build a new root and evolve from the root to the current state of the SimpleTypeHandler, then replace the type's existing SimpleTypeHandler with the new PathTypeHandler. From there, we can evolve to the state required by the new property/attribute, and future instances of the same function that make the same type transition will get the same type. Also fix up some shared SimpleTypeHandler's in the library that didn't represent the desired state of their library objects and were forcing type transitions during initialization.