Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide ScrollToEnd button through style options #2332

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Add hide ScrollToEnd button through style options #2332

merged 2 commits into from
Aug 19, 2019

Conversation

nt-7
Copy link
Contributor

@nt-7 nt-7 commented Aug 19, 2019

Add option to hide scroll button #2307

Description

This work will enable to hide the ScrollToEndButton ("New messages") through style options from webchat UI when scrolling.

image

Example

As below, hideScrollToEndButton on styleOptions enable users to hide the ScrollToEndButton from webchat UI.

const styleOptions = {
    hideScrollToEndButton: false
};
window.WebChat.renderWebChat({
    directLine: window.WebChat.createDirectLine({ token }),
    styleOptions
}, document.getElementById('webchat'));

@coveralls
Copy link

coveralls commented Aug 19, 2019

Coverage Status

Coverage increased (+0.02%) to 66.13% when pulling 0400213 on nt-7:hide-scroll-button into 007d5dc on microsoft:master.

@tdurnford
Copy link
Contributor

tdurnford commented Aug 19, 2019

Thanks for your contribution! Would you mind adding a CHANGELOG entry to your PR?

@nt-7
Copy link
Contributor Author

nt-7 commented Aug 19, 2019

@tdurnford thanks for your response! I updated CHANGELOG now.

@corinagum corinagum merged commit 011eae8 into microsoft:master Aug 19, 2019
@corinagum
Copy link
Contributor

Thank you for your contribution! :)

corinagum pushed a commit that referenced this pull request Oct 29, 2019
* Add test for #2331

* Add test for hiding scroll to bottom button

* Add test for YouTube full screen control

* Reliability

* Filter out DIRECT_LINE/CONNECT* actions

* Set payload.directLine to empty object

* Filter out payload.directLine

* Better filtering
@compulim compulim mentioned this pull request Dec 10, 2019
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants