Got rid of node Buffer() deprecation warnings. #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
justinwilaby
as code owners
Pull Request Test Coverage Report for Build 2495
💛 - Coveralls |
justinwilaby
previously approved these changes
Apr 12, 2019
tonyanziano
force-pushed
the
toanzian/buffer-warning
branch
from
8c8c528 to
8626e18
Compare
justinwilaby
previously approved these changes
Apr 15, 2019
tonyanziano
force-pushed
the
toanzian/buffer-warning
branch
from
8626e18 to
dc5a9ef
Compare
tonyanziano
force-pushed
the
toanzian/buffer-warning
branch
from
dc5a9ef to
1940c0c
Compare
justinwilaby
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect of bumping Electron a new node deprecation warning has surfaced. This fixes it.