Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ExceptionTelemetry.SetParsedStack for .netstandard? #763

Closed
defr0std opened this issue Apr 11, 2018 · 2 comments
Closed

Enable ExceptionTelemetry.SetParsedStack for .netstandard? #763

defr0std opened this issue Apr 11, 2018 · 2 comments
Labels
enhancement
Milestone
2.6-Beta4

Comments

@defr0std
Copy link

The method ExceptionTelemetry.SetParsedStack is not available for .netstandard.

Is there a reason why it is under #if? It seems to depend only on StackFrame and ExceptionConverter which are referenced anyway.
@TimothyMothra
Copy link
Member

@SergeyKanzhelev are you aware of any reason this constraint is present? It was added here.

I removed it and everything compiles and all the tests pass.

If there's no reason to keep this constraint, I propose removing it.

@SergeyKanzhelev
Copy link
Contributor

no specific reasons. Feel free to remove conditional compilation

@TimothyMothra TimothyMothra mentioned this issue Apr 11, 2018
Merged
4 tasks
@TimothyMothra TimothyMothra added this to the 2.6-Beta4 milestone Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.6-Beta4
Development

No branches or pull requests
3 participants
@SergeyKanzhelev @defr0std @TimothyMothra