Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Do not produce dependency items for the quick pulse calls #196

Closed
SergeyKanzhelev opened this issue Nov 3, 2016 · 6 comments
Closed

Do not produce dependency items for the quick pulse calls #196

SergeyKanzhelev opened this issue Nov 3, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@SergeyKanzhelev
Copy link
Contributor

Using app insights in VS I keep seeing these “Dependecy /QuickPulseService.svc” lines show up

image

What is this? It’s kind of annoying that it shows up every 5 seconds!

VS shows all telemetry items – filtered and not filtered. One of the reasons for this is that we wanted to show “sampled out” requests in the local search. If QP generate dependencies events – SDK spends many cycles to allocate and initialize those. So this is clearly a wasted effort.

I think the solution is to filter those calls in Dependency Tracking module, not in the filter.

@SergeyKanzhelev
Copy link
Contributor Author

I think both should be happening:

  1. Filtering in Dependency Collector by default
  2. As @gardnerjr pointed - this should be included into filtering processor:
if (IsQuickPulse(item))
{
    TelemetryDebugWriter.WriteTelemetry(item, "QuickPulse Filtering");
    return;
}

It will ends up with the prefix: Application Insights Telemetry (filtered by QuickPulse Filtering): in the output that will be marked by VSIX

@gardnerjr
Copy link

the above was just what i did locally in a filter to make them go away in one of my projects and test the filtering, but yes, there should be some filtering by the AI SDK itself, it shouldn't be considering outbound quickpulse calls to be "dependencies" in my application.

from the SDK side, i don't think there should even be the TelemetryDebugWriter call, as it isn't real telemetry. it should get filtered out silently, it isn't telemetry being sent by my application and not clog up output windows or debug tools.

@cijothomas
Copy link
Contributor

The quickpulse dependency is showing in Ibiza portal as well..

@gardnerjr
Copy link

@cijothomas yes, because they're getting sent, that's the bug :) once they're sent, they show up everywhere. VS search, AA, Ibiza, Draft, powerbi, etc.

@cijothomas
Copy link
Contributor

yea will fix it.. too much noise this is causing while debugging.

@AlexBulankou
Copy link

We misunderstood the issue :( We thought it was only showing in VS. Yes, need to fix for 2.2 Stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants