-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to enumerate all images contained in card #1094
Labels
Comments
andrewleader
added
Area-Renderers
Platform-XAML
Bugs or features related to Xaml Renderer
High Priority
Tag-Toasts-V2
Epic
labels
Feb 1, 2018
Changing priority to Tag-Toasts-V1 since it turns out this is required for Action Center to support ms-appx/ms-appdata images too, not just http, so it's something critical for RS5 |
khouzam
changed the title
API to enumerate all images contained in card
API to enumerate all images contained in card for UWP
May 24, 2018
khouzam
changed the title
API to enumerate all images contained in card for UWP
API to enumerate all images contained in card
Jun 6, 2018
This was referenced Jun 28, 2018
Documentation is done and in the mahiding/site1.1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Implementation status
Scenario
Toast notifications need to pre-load HTTP images in non-UI threads, so before any calls to Render (and any XAML tree creation) occurs.
Proposed solution
Provide an API to enumerate all images contained in a card. It's not realistic for card authors like toasts to enumerate through body/action elements themselves, since images could be contained inside columns or even inside ShowCards. This enumeration would have to be maintained and owned by Adaptive Cards.
API returns all image URIs, like
https://msn.com/img.png
,ms-appx:///Assets/taco.png
, etc... Action Center can then filter themselves whether it's a remote web image or not.Pulls from...
Container
Column
ShowCard
Action
(once Action is updated to support images)I'm not picky on the API name or the return type.
The text was updated successfully, but these errors were encountered: