Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of epoch divides incorrectly #13

Closed
lemmersj opened this issue Aug 16, 2019 · 1 comment
Closed

End of epoch divides incorrectly #13

lemmersj opened this issue Aug 16, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lemmersj
Copy link
Collaborator

The logging loss sum appears to be divided by the expected number of samples (i.e., the full minibatch size), instead of the actual samples processed. This results in an abrupt reduction in magnitude of the logged loss when an epoch ends.

division

@lemmersj lemmersj added the bug Something isn't working label Aug 16, 2019
@zeonzir zeonzir self-assigned this Aug 16, 2019
@zeonzir
Copy link
Collaborator

zeonzir commented Aug 23, 2019

Completed fix by adding a running batch counter to account to true batch size being processed as opposed the hard calculation of pseudo_batch_looper * batch_size. Will be reviewed soon and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants