Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate dimmer implementations #155

Closed
MichielVanwelsenaere opened this issue Feb 24, 2024 · 0 comments · Fixed by #160
Closed

Seperate dimmer implementations #155

MichielVanwelsenaere opened this issue Feb 24, 2024 · 0 comments · Fixed by #160
Assignees
@MichielVanwelsenaere
Labels
enhancement New feature or request

Comments

@MichielVanwelsenaere
Copy link
Owner

in the current implementation the regular Analog dimmer and DMX dimmer functionality are implemented in the same function block.
To avoid confusion and breaking changes/regression on either it would be best to seperate them.

Attached a confirmed working implementation of the Analog dimmer without DMX functionality for the implemenation.
FB_OUTPUT_DIMMER_MQTT_ANALOG.export.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichielVanwelsenaere MichielVanwelsenaere

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Seperating dimmer and dmx logic MichielVanwelsenaere/HomeAutomation.CoDeSys3
1 participant
@MichielVanwelsenaere