-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Soundcloud embeds for songs and playlists #9
Add Soundcloud embeds for songs and playlists #9
Conversation
gorgeous! |
Hi @MichaelDeBoey! Any feedback on this guy? ☝️ Also -- thanks @sw-yx, I appreciate your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicknish!
I'm sorry for the late response, but apparently my notifications for this repo were disabled somehow. 😕
Thanks for taking your time to implement the SoundCloud transformer!
Really awesome work.
I've added some small improvements and better default-values (imo) before this one can be merged.
Let me know if you need some further help. 🙂
@MichaelDeBoey Hi Michael. Thanks for taking a peek at my PR. 🎉 I updated it with your suggestions:
|
@MichaelDeBoey Phew. Got rid of all those pesky trailing slashes. 😄 All ready for 👀again |
All resolved. Will keep an eye on notifications in case there are any other changes necessary. I'll also keep in mind the changes here when making future contributions 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems good to be merged.
You just have to add the transformer in the main file, otherwise it won't run.
@MichaelDeBoey all set! Thanks for your patience with this one 😄 |
…on to 1-line template literal
2c2931d
to
b2acd99
Compare
@nicknish No problem at all! 🙂 Did some small nitpicks, but all good. Thanks for the great contribution! 👊 |
@all-contributors Please add @nicknish for code and test |
I've put up a pull request to add @nicknish! 🎉 |
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hello! After sorting through some trouble with other gatsby embed plugins, I found this project a few days ago and I'm already excited about it. Thanks for the hard work!
I saw that Soundcloud embeds was an issue in #3, so I went ahead and gave it a go.
Closes #3
What:
Add Soundcloud embeds
Why:
Existing issue #3
How:
https://soundcloud.com/clemenswenners/africa
)Screenshots:
I created a CodeSandbox example to demo the output and to compare its appearance to the typical Soundcloud embed. Check it out below
https://codesandbox.io/s/soundcloud-dynamic-embed-zkjm9
*Implementation Notes:
Checklist: